fix: stop holding Pubsub mutex while calling pq.Listener #12518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spikecurtis and the rest of your teammates on |
e3c30f7 to
194eb5f
Compare
kylecarbs
approved these changes
Mar 11, 2024
deansheather
approved these changes
Mar 11, 2024
194eb5f to
79b2e92
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11950
#11950 (comment) explains the bug
We were also calling into
Unlisten()andClose()while holding the mutex. I don't believe thatClose()depends on the notification loop being unblocked, but it's hard to be sure, and the safest thing to do is assume it could block.So, I added a unit test that fakes out
pq.Listenerand sends a bunch of notifies every time we call into it to hopefully prevent regression where we hold the mutex while calling into these functions.It also removes the use of a
context.Contextto stop the PubSub -- it must be explicitlyClosed(). This simplifies a bunch of the logic, and is how we use the pubsub anyway.