Skip to content

fix: revert "feat: make agent stats' cardinality configurable (#12468)" #12533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix: revert "feat: make agent stats' cardinality configurable (#12468)" #12533

merged 1 commit into from
Mar 11, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Mar 11, 2024 •
edited
Loading

This reverts commit 21d1873.

panic: inconsistent label cardinality: expected 4 label values but got 3 in []string{"dev", "ammar", "c0"}                                                                                                                                │
│                                                                                                                                                                                                                                           │
│ goroutine 161 [running]:                                                                                                                                                                                                                  │
│ github.com/prometheus/client_golang/prometheus.(*GaugeVec).WithLabelValues(...)                                                                                                                                                           │
│     /home/runner/go/pkg/mod/github.com/prometheus/client_golang@v1.18.0/prometheus/gauge.go:238                                                                                                                                           │
│ github.com/coder/coder/v2/coderd/prometheusmetrics.(*CachedGaugeVec).Commit(0xc00150ee10)                                                                                                                                                 │
│     /home/runner/actions-runner/_work/coder/coder/coderd/prometheusmetrics/collector.go:84 +0x191                                                                                                                                         │
│ github.com/coder/coder/v2/coderd/prometheusmetrics.AgentStats.func1()                                                                                                                                                                     │
│     /home/runner/actions-runner/_work/coder/coder/coderd/prometheusmetrics/prometheusmetrics.go:492 +0x885                                                                                                                                │
│ created by github.com/coder/coder/v2/coderd/prometheusmetrics.AgentStats in goroutine 1                                                                                                                                                   │
│     /home/runner/actions-runner/_work/coder/coder/coderd/prometheusmetrics/prometheusmetrics.go:448 +0x1445

@johnstcn johnstcn changed the title Revert "feat: make agent stats' cardinality configurable (#12468)" fix: revert "feat: make agent stats' cardinality configurable (#12468)" Mar 11, 2024
dannykopping
dannykopping approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting due to a panic: inconsistent label cardinality observed in pre-prod

@johnstcn johnstcn enabled auto-merge (squash) March 11, 2024 14:30
@johnstcn johnstcn merged commit 8f40ee3 into main Mar 11, 2024
@johnstcn johnstcn deleted the cj/revert-12468 branch March 11, 2024 14:33
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@dannykopping dannykopping dannykopping approved these changes

@mtojek mtojek Awaiting requested review from mtojek

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnstcn @mafredri @dannykopping