Skip to content

feat: make agent stats' cardinality configurable #12535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Mar 13, 2024
Merged

feat: make agent stats' cardinality configurable #12535

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
975caa5
Initial implementation
dannykopping Mar 7, 2024
fcaebb3
Refactoring
dannykopping Mar 8, 2024
70102f8
Drive-by change to add delve to nix flake so ./scripts/develop.sh --d…
dannykopping Mar 8, 2024
e3bfa0d
Update deployment config
dannykopping Mar 8, 2024
92e538a
Linting
dannykopping Mar 8, 2024
fd19896
Control cardinality of coderd metrics as well
dannykopping Mar 8, 2024
a682843
Remove default value
dannykopping Mar 8, 2024
48b68ad
make fmt && make gen
dannykopping Mar 8, 2024
661f5c2
Appeasing CI
dannykopping Mar 8, 2024
7d3ded4
Appeasing CI, again...
dannykopping Mar 8, 2024
defcf74
...
dannykopping Mar 8, 2024
97f2bd1
Review comments & CI appeasement
dannykopping Mar 11, 2024
8f2c505
More review comments & CI appeasement
dannykopping Mar 11, 2024
c0896a7
Fixing lints
dannykopping Mar 11, 2024
c11dc61
chore(dogfood): update keys
johnstcn Mar 11, 2024
cdd6734
Fix flaky label evaluation by sorting both sides
dannykopping Mar 11, 2024
06f2f87
Update node key
dannykopping Mar 11, 2024
3c1d016
Filter out unacceptable labels in AgentStats
dannykopping Mar 11, 2024
f8ebdf2
make fmt
dannykopping Mar 11, 2024
05e5cd0
Merge branch 'dk/configurable-cardinality' of github.com:dannykopping…
dannykopping Mar 12, 2024
b1ef0d6
Merge branch 'main' of github.com:/coder/coder into dk/configurable-c…
dannykopping Mar 12, 2024
a669411
Review comments
dannykopping Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Appeasing CI, again... 
Signed-off-by: Danny Kopping <danny@coder.com>
  • Loading branch information
@dannykopping
dannykopping committed Mar 11, 2024
commit 7d3ded4fd2e5d6f97333895bb42ba941a7dfd8cb
6 changes: 3 additions & 3 deletions cli/testdata/server-config.yaml.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,14 +188,14 @@ introspection:
# Collect agent stats (may increase charges for metrics storage).
# (default: <unset>, type: bool)
collect_agent_stats: false
# Collect database metrics (may increase charges for metrics storage).
# (default: false, type: bool)
collect_db_metrics: false
# When collecting agent stats, aggregate metrics by a given set of comma-separated
# labels to reduce cardinality. Accepted values are template_name, agent_name,
# username, workspace_name.
# (default: <unset>, type: string-array)
aggregate_agent_stats_by: []
# Collect database metrics (may increase charges for metrics storage).
# (default: false, type: bool)
collect_db_metrics: false
pprof:
# Serve pprof metrics on the address defined by pprof address.
# (default: <unset>, type: bool)
Expand Down
4 changes: 2 additions & 2 deletions coderd/prometheusmetrics/aggregator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,8 @@ func TestUpdateMetrics_MetricsExpire(t *testing.T) {
}

func TestLabelsAggregation(t *testing.T) {
t.Parallel()

type statCollection struct {
labels prometheusmetrics.AgentMetricLabels
metrics []*agentproto.Stats_Metric
Expand Down Expand Up @@ -559,8 +561,6 @@ func TestLabelsAggregation(t *testing.T) {
}

for _, tc := range tests {
t.Parallel()

t.Run(tc.name, func(t *testing.T) {
// given
registry := prometheus.NewRegistry()
Expand Down