chore(codersdk): explain format of codersdk.UpdateWorkspaceAutostartRequest.Schedule #12539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stirby
approved these changes
Mar 11, 2024
kylecarbs
reviewed
Mar 11, 2024
| @@ -253,6 +253,9 @@ func (c *Client) UpdateWorkspace(ctx context.Context, id uuid.UUID, req UpdateWo | |||
|
|
|||
| // UpdateWorkspaceAutostartRequest is a request to update a workspace's autostart schedule. | |||
| type UpdateWorkspaceAutostartRequest struct { | |||
| // Schedule is expected to be of the form `CRON_TZ=<IANA Timezone> <min> <hour> * * <dow>` | |||
There was a problem hiding this comment.
Is there a reason we don't deprecate this field and instead make CronTimezone the property on the struct?
There was a problem hiding this comment.
Could definitely do this! Main reason was to document. Will file a follow-up.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.