fix: Use cliui.WorkspaceBuild to prevent cancel of builds jobs
#1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build jobs cannot gracefully terminate because Terraform generally cannot gracefully terminate.
Codecov Report
@@ Coverage Diff @@
## main #1255 +/- ##
==========================================
+ Coverage 65.93% 66.06% +0.13%
==========================================
Files 272 275 +3
Lines 17892 17937 +45
Branches 192 214 +22
==========================================
+ Hits 11797 11850 +53
+ Misses 4871 4855 -16
- Partials 1224 1232 +8
Continue to review full report at Codecov.
|
deansheather
approved these changes
May 2, 2022
|
We do support build cancellation, but it's better for infrastructure folks to rely on Terraform timeouts instead. I'm going to be making significant changes here this week. |
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
Build jobs cannot gracefully terminate because Terraform generally cannot gracefully terminate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build jobs cannot gracefully terminate because Terraform generally
cannot gracefully terminate.