Skip to content

chore(site): refactor logs and add stories #12553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 14, 2024
Merged

chore(site): refactor logs and add stories #12553

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4099ba6
Refact log components
BrunoQuaresma Mar 12, 2024
6f46085
Add stories for LogLine
BrunoQuaresma Mar 12, 2024
23b3910
Fix source_id prop
BrunoQuaresma Mar 12, 2024
c3e39a1
Fix resource_id parametters
BrunoQuaresma Mar 12, 2024
cb7cda9
Fix line height
BrunoQuaresma Mar 12, 2024
8b5a831
Apply PR review suggestions
BrunoQuaresma Mar 13, 2024
53dcd35
Fix missing log line space
BrunoQuaresma Mar 13, 2024
5e6222a
Add output comment
BrunoQuaresma Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix missing log line space
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Mar 13, 2024
commit 53dcd3584901ed82a12bb907050cfa9bdde4935a
11 changes: 4 additions & 7 deletions site/src/components/Logs/Logs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { Interpolation, Theme } from "@emotion/react";
import dayjs from "dayjs";
import type { FC } from "react";
import { LogLinePrefix, LogLineSpace, LogLine, type Line } from "./LogLine";
import { LogLinePrefix, LogLine, type Line } from "./LogLine";

export const DEFAULT_LOG_LINE_SIDE_PADDING = 24;

Expand All @@ -22,12 +22,9 @@ export const Logs: FC<LogsProps> = ({
{lines.map((line, idx) => (
<LogLine key={idx} level={line.level}>
{!hideTimestamps && (
<>
<LogLinePrefix>
{dayjs(line.time).format(`HH:mm:ss.SSS`)}
</LogLinePrefix>
<LogLineSpace />
</>
<LogLinePrefix>
{dayjs(line.time).format(`HH:mm:ss.SSS`)}
</LogLinePrefix>
)}
<span>{line.output}</span>
</LogLine>
Expand Down