-
Notifications
You must be signed in to change notification settings - Fork 887
fix(support): sanitize agent env #12554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm wondering if we should rather use an allowlist rather than a denylist? |
That's interesting. This would also catch someone randomly adding an agent environment variable. I'll look into that. EDIT: agent environment variables are likely not what we would need for debugging anyway; we'd be more interested in the underlying compute resource (e.g. Docker container). I'll just scrub all the values and be done with it. WDYT? |
dc33666
to
06c2ac6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
06c2ac6
to
e13e5b3
Compare
We don't want support bundles leaking users' OIDC tokens etc.