fix: Prefix buildinfo tag with "v" #1256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1256 +/- ##
==========================================
+ Coverage 65.80% 65.87% +0.07%
==========================================
Files 275 272 -3
Lines 17972 17784 -188
Branches 214 216 +2
==========================================
- Hits 11826 11715 -111
+ Misses 4907 4843 -64
+ Partials 1239 1226 -13
Continue to review full report at Codecov.
|
coadler
approved these changes
May 2, 2022
buildinfo/buildinfo.go
Outdated
| if semver.Build(tag) == "" { | ||
| // The tag must be prefixed with "v" otherwise the | ||
| // semver library will return an empty string. | ||
| if semver.Build("v"+tag) == "" { | ||
| tag += revision | ||
| } | ||
| version = "v" + tag |
There was a problem hiding this comment.
Why not just move this above the semver.Build
This fixes the format of production and development build tags.
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
This fixes the format of production and development build tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the format of production and development build
tags.