fix: Adjust Makefile tagets to use dependencies #1259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was getting slow to run `make gen` and other operations, but this resolves it by targeting files properly.
Codecov Report
@@ Coverage Diff @@
## main #1259 +/- ##
==========================================
+ Coverage 66.11% 66.22% +0.10%
==========================================
Files 275 275
Lines 17948 17952 +4
Branches 216 216
==========================================
+ Hits 11867 11889 +22
+ Misses 4847 4831 -16
+ Partials 1234 1232 -2
Continue to review full report at Codecov.
|
coadler
approved these changes
May 2, 2022
f0ssel
approved these changes
May 2, 2022
kylecarbs
added a commit
that referenced
this pull request
May 2, 2022
This was a missed item in #1259.
kylecarbs
added a commit
that referenced
this pull request
May 2, 2022
This was a missed item in #1259.
kylecarbs
added a commit
that referenced
this pull request
May 2, 2022
This was a missed item in #1259.
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
It was getting slow to run `make gen` and other operations, but this resolves it by targeting files properly.
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
This was a missed item in #1259.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was getting slow to run
make genand other operations,but this resolves it by targeting files properly.