feat(codersdk): add debug handlers for logs, manifest, and token to agent #12593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Mar 14, 2024
| } | ||
| defer f.Close() | ||
|
|
||
| // Limit to 10MB. |
There was a problem hiding this comment.
Should we limit this in the head or tail-end? A workspace running for a long time could have more relevant information towards the end. Then again, we seem to rotate at 5 MB so this will essentially always give the tail.
There was a problem hiding this comment.
Yep, this was my thinking. I was thinking about tailing but the fact that we rotate makes this not as important.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12161
Adds the following debug handlers to the agent API:
/debug/manifest: returns the in-memory agent manifest/debug/token: returns the in-memory agent session token/debug/logs: returns up to the last 10MB of the agent log.We can technically get these by connecting to the agent over SSH but this seems to be a better way overall.