Skip to content

fix: handle CLI default organization when none exists in <v2.9.0 coderd #12594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Mar 14, 2024

If the coder cli is talking to an older version of Coderd, the isDefault field will be false.

This can also happen if a user does not belong to the default org.

@Emyrk Emyrk changed the title chore: 'coder org set' help message was incorrect fix: cli default org when no default org exists (older coderd) Mar 14, 2024
@Emyrk Emyrk changed the title fix: cli default org when no default org exists (older coderd) fix: handle CLI default organization when none exists in <v2.9.0 coderd Mar 14, 2024
@Emyrk Emyrk requested a review from kylecarbs March 14, 2024 14:25
@Emyrk Emyrk requested a review from mafredri March 14, 2024 16:20
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a comment when we can remove this, just so it doesn't live forever.

@Emyrk
Copy link
Member Author

Emyrk commented Mar 14, 2024

You should add a comment when we can remove this, just so it doesn't live forever.

I thought about it and this can actually occur in the future too. If you create a new user to a single organization, and that org is not the default, this remains helpful.

@Emyrk Emyrk merged commit 29c8cf2 into main Mar 14, 2024
@Emyrk Emyrk deleted the stevenmasley/set_org_help branch March 14, 2024 20:11
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants