Skip to content

chore(site): upgrade msw to 2.0 #12597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 19, 2024
Merged

chore(site): upgrade msw to 2.0 #12597

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
3e0e2e2
wp: upgrade msw
BrunoQuaresma Mar 8, 2024
d385f53
Minor fixes
BrunoQuaresma Mar 8, 2024
41fcf23
Fix polyfill issues and ProxyContext old api usage
BrunoQuaresma Mar 14, 2024
7855226
Fix PortForwardPopoverView tests
BrunoQuaresma Mar 14, 2024
41ccf83
Skip usePaginatedQuery.test
BrunoQuaresma Mar 14, 2024
b641691
Merge branch 'main' of https://github.com/coder/coder into bq/upgrade…
BrunoQuaresma Mar 14, 2024
c5f758a
Skip usePaginatedQuery test
BrunoQuaresma Mar 14, 2024
3c3db52
Fix fmt
BrunoQuaresma Mar 14, 2024
723ccd9
Fix lint
BrunoQuaresma Mar 14, 2024
4c61c01
fix typo
BrunoQuaresma Mar 18, 2024
a70d24c
Remove ynecessary async
BrunoQuaresma Mar 18, 2024
8f5748a
Merge branch 'main' of https://github.com/coder/coder into bq/upgrade…
BrunoQuaresma Mar 18, 2024
374f6c4
Fix metadata stuff
BrunoQuaresma Mar 18, 2024
089680d
Improve type
BrunoQuaresma Mar 18, 2024
538f1e2
Merge branch 'main' of https://github.com/coder/coder into bq/upgrade…
BrunoQuaresma Mar 18, 2024
d5d8788
Merge branch 'main' of https://github.com/coder/coder into bq/upgrade…
BrunoQuaresma Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip usePaginatedQuery test
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Mar 14, 2024
commit c5f758a77a6e53057a37d6138dc08295233b274d
9 changes: 8 additions & 1 deletion site/jest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,14 @@ module.exports = {
customExportConditions: [""],
},
testRegex: "(/__tests__/.*|(\\.|/)(test|spec))\\.tsx?$",
testPathIgnorePatterns: ["/node_modules/", "/e2e/"],
testPathIgnorePatterns: [
"/node_modules/",
"/e2e/",
// TODO: This test is timing out after upgrade a few Jest dependencies
// and I was not able to figure out why. When running it specifically, I
// can see many act warnings that may can help us to find the issue.
"/usePaginatedQuery.test.ts",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Parkreiner I may need your help with this 🙏 I created a separated issue to not block this one #12598

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! Happy to take a look tomorrow after Backstage launch

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than temporarily ignore the file, can we use test.failing on the tests in the file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't realize that was an option. Definitely think we should go with that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, https://jestjs.io/docs/api#testskipfailingname-fn-timeout :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, describe.skip or test.failure are not working 😢 it just hangs forever

Screen.Recording.2024-03-14.at.14.54.43.mov

Ps: I tried to post a longer video but GH didn't allow me because of the size.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's annoying... what happens if you add an empty non-skipped test?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it just hangs... I think there is some weird thing happening on this test 🤔

],
transformIgnorePatterns: [
"<rootDir>/node_modules/@chartjs-adapter-date-fns",
],
Expand Down