feat(cli): show queue position during workspace builds #12606
Conversation
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
| e.t.Helper() | ||
|
|
||
| timeout, cancel := context.WithTimeout(context.Background(), testutil.WaitMedium) | ||
| defer cancel() | ||
|
|
||
| return e.ExpectMatchContext(timeout, str) | ||
| return impl(timeout, str) | ||
| } | ||
|
|
||
| // TODO(mafredri): Rename this to ExpectMatch when refactoring. |
There was a problem hiding this comment.
@mafredri not really sure what this TODO is about since both this and the ExpectMatch functions have lots of usage. Could you elaborate please?
There was a problem hiding this comment.
Essentially the non-context variant should be marked deprecated. All usage switched to context. Then delete the non-context one and rename this to not have context in the name.
There was a problem hiding this comment.
OK, is it because we need to be able to control the deadline?
I think I'll do that in a separate PR.
Signed-off-by: Danny Kopping <danny@coder.com>
|
We are now showing queue position in the workspace list page, and also on the CI. A nice to have would be to add an expandable table that lists the jobs/workspaces currently in queue for each of them. |
Should be doable, but is out of scope for this issue. |
Fixes #9434
Note for the reviewer:
stopandstartEach time the position in the queue changes, an update will be printed