Skip to content

fix(examples/lima/coder.yaml): update base image, remove usage of deprecated LIMA_CIDATA #12613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Mar 15, 2024

  • Updates base image used by lima config
  • Removes usage of deprecated LIMA_CIDATA
  • Names docker template consistently (we were appending $ARCH before)

To kick the tyres:

limactl start  --name=coder examples/lima/coder.yaml

…recated LIMA_CIDATA, name template consistently
@johnstcn johnstcn requested review from mafredri and f0ssel March 15, 2024 16:10
@johnstcn johnstcn self-assigned this Mar 15, 2024
@johnstcn johnstcn changed the title fix(examples/lima/coder.yaml): update base image, remove usage of deprecated LIMA_CIDATA, name template consistently fix(examples/lima/coder.yaml): update base image, remove usage of deprecated LIMA_CIDATA Mar 15, 2024
@@ -63,7 +62,7 @@ provision:
# SSH session around. We don't want users to have to manually delete ~/.lima/$VM/ssh.sock
# so we're just instead going to modify the perms on the Docker socket.
# See: https://github.com/lima-vm/lima/issues/528
chown ${LIMA_CIDATA_USER} /var/run/docker.sock
chown {{.User}} /var/run/docker.sock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this yaml processed by Go templating? Or is this something else?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, lima formats it.

@johnstcn johnstcn merged commit 25b605f into main Mar 15, 2024
@johnstcn johnstcn deleted the cj/lima-updates branch March 15, 2024 17:22
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants