fix(cli): show error/hide help for unsupported subcommands (#10760) #12624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef62f90 to
6fa4ef3
Compare
…er#10760) The coder CLI quietly accepts any subcommand arguments and silently swallows them. Currently: ❯ coder idontexist | head -n5 coder v2.3.3+e491217 USAGE: coder [global-flags] <subcommand> Now help output will not be show but users will be given the command for the help output. ❯ coder idontexist Encountered an error running "coder", see "coder --help" for more information error: unrecognized subcommand "idontexist" ❯ coder iexistbut idontexist Encountered an error running "coder iexistbut", see "coder iexistbut --help" for more information unrecognized subcommand "idontexist"
6fa4ef3 to
446a9c0
Compare
ammario
approved these changes
Mar 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10760
The coder CLI quietly accepts any subcommand arguments and silently swallows them.
Currently:
Now help output will not be show when there is an unknown subcommand error. Instead users will be given the command for the help output.
Also this stuff:
Encountered an error running "coder iexistbut"...gets written toos.StdoutinprettyErrorFormatter{w: os.Stderr, verbose: r.verbose}, not sure how to test that output.