feat: Add "state" command to pull and push workspace state #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1264 +/- ##
==========================================
+ Coverage 65.90% 66.01% +0.10%
==========================================
Files 275 276 +1
Lines 18034 18146 +112
Branches 216 216
==========================================
+ Hits 11886 11979 +93
- Misses 4913 4925 +12
- Partials 1235 1242 +7
Continue to review full report at Codecov.
|
coadler
reviewed
May 2, 2022
| var buildName string | ||
| cmd := &cobra.Command{ | ||
| Use: "pull <workspace> [file]", | ||
| RunE: func(cmd *cobra.Command, args []string) error { |
There was a problem hiding this comment.
I think this needs a cobra.MinimumNArgs(1)
It's possible for a workspace to become in an invalid state. This is something we'll detect for jobs, and allow monitoring of. These commands will allow admins to manually reconcile state.
coadler
approved these changes
May 2, 2022
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
It's possible for a workspace to become in an invalid state. This is something we'll detect for jobs, and allow monitoring of. These commands will allow admins to manually reconcile state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for a workspace to become in an invalid state.
This is something we'll detect for jobs, and allow monitoring of.
These commands will allow admins to manually reconcile state.
When the state is pushed, should we require a new workspace build to be created? That seems like a better approach than replacing it.