Skip to content

chore!: remove max_ttl from templates #12644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 20, 2024
Merged

chore!: remove max_ttl from templates #12644

merged 10 commits into from
Mar 20, 2024

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Mar 18, 2024 •
edited
Loading

Completely removing max_ttl as a feature on template scheduling

Closes #11692

Anyone currently using autostart will no longer have an maxDeadline set by this. I do not know of a good migration to resolve this, since the new feature is so different.

Verify it is all gone

grep -nri 'max[^s]*ttl'  --exclude-dir=build --exclude-dir=.idea --exclude-dir=.git --exclude-dir=migrations --exclude-dir=out --exclude-dir=node_modules .

@Emyrk Emyrk force-pushed the stevenmasley/remove_max_ttl branch from 2dc865d to 6ee1229 Compare March 18, 2024 20:35
@Emyrk Emyrk force-pushed the stevenmasley/remove_max_ttl branch from e49d651 to e675495 Compare March 19, 2024 15:14
@Emyrk Emyrk marked this pull request as ready for review March 19, 2024 18:23
@Emyrk Emyrk requested a review from deansheather March 20, 2024 14:38
deansheather
deansheather approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend LGTM

@Emyrk Emyrk added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Mar 20, 2024
@github-actions github-actions bot changed the title chore: remove max_ttl from templates chore!: remove max_ttl from templates Mar 20, 2024
@Emyrk Emyrk merged commit d789a60 into main Mar 20, 2024
@Emyrk Emyrk deleted the stevenmasley/remove_max_ttl branch March 20, 2024 15:37
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees

@Emyrk Emyrk

Labels
release/breaking This label is applied to PRs to detect breaking changes as part of the release process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove max_ttl in favor of Autostop Requirement
2 participants
@Emyrk @deansheather