Skip to content

fix: disable relay if built-in DERP is disabled #12654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix: disable relay if built-in DERP is disabled #12654

merged 1 commit into from
Mar 21, 2024

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Mar 18, 2024 •
edited
Loading

Fixes #12493

@coadler Graphite App
Copy link
Contributor Author

coadler commented Mar 18, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @coadler and the rest of your teammates on Graphite Graphite

@coadler coadler marked this pull request as ready for review March 18, 2024 22:33
kylecarbs
kylecarbs approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test!!!

@coadler coadler force-pushed the colin/fix_disable_relay_if_built-in_derp_is_disabled branch from d16d19d to db9ab15 Compare March 20, 2024 20:37
@coadler coadler force-pushed the colin/fix_disable_relay_if_built-in_derp_is_disabled branch from db9ab15 to 76ebfd8 Compare March 21, 2024 21:32
@coadler coadler merged commit 37a0537 into main Mar 21, 2024
@coadler coadler deleted the colin/fix_disable_relay_if_built-in_derp_is_disabled branch March 21, 2024 21:53
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DERP Relay URL shouldn't be required if DERP server is disabled
2 participants
@coadler @kylecarbs