Skip to content

chore: helm golden file test log output on failure #12661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2024
Merged

chore: helm golden file test log output on failure #12661

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7259ebb
chore: helm golden file test log output on failure
Emyrk Mar 19, 2024
c5f406c
fmt
Emyrk Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: helm golden file test log output on failure 
Debugging this is hard without the actual helm error
  • Loading branch information
@Emyrk
Emyrk committed Mar 19, 2024
commit 7259ebbb8e17b47a695d7b4dab500a16ba37922f
3 changes: 3 additions & 0 deletions helm/provisioner/tests/chart_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,9 @@ func TestUpdateGoldenFiles(t *testing.T) {
valuesPath := tc.valuesFilePath()
templateOutput, err := runHelmTemplate(t, helmPath, "..", valuesPath)

if err != nil {
t.Logf("Command output:\n%s", templateOutput)
}
require.NoError(t, err, "failed to run `helm template -f %q`", valuesPath)

goldenFilePath := tc.goldenFilePath()
Expand Down