Skip to content

feat(coderd/database): use template_usage_stats in *ByTemplate insights queries #12668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 25, 2024
Merged

feat(coderd/database): use template_usage_stats in *ByTemplate insights queries #12668

merged 11 commits into from
Mar 25, 2024

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Mar 19, 2024 •
edited
Loading

This PR updates the *ByTempalte insights queries used for generating Prometheus metrics to behave the same way as the new rollup query and re-written insights queries that utilize the rolled up data.

This was referenced Mar 19, 2024
Merged
Merged
Merged
@mafredri Graphite App
Copy link
Member Author

mafredri commented Mar 19, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mafredri and the rest of your teammates on Graphite Graphite

@mafredri mafredri mentioned this pull request Mar 19, 2024
Merged
This was referenced Mar 19, 2024
Merged
Closed
Merged
Merged
Merged
Merged
Merged
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbyinterval branch from fc42977 to e64a1b0 Compare March 19, 2024 16:24
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from f369461 to 2eae8f8 Compare March 19, 2024 16:24
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbyinterval branch from e64a1b0 to f0ceeea Compare March 20, 2024 10:25
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from 2eae8f8 to 4ae3521 Compare March 20, 2024 10:25
mtojek
mtojek approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, stamp

@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbyinterval branch from f0ceeea to b10b9dd Compare March 20, 2024 12:37
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from 4ae3521 to 2ac8855 Compare March 20, 2024 12:37
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbyinterval branch from b10b9dd to 20b839e Compare March 20, 2024 14:13
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from 2ac8855 to 5b0d0bb Compare March 20, 2024 14:21
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbyinterval branch from 20b839e to 67c6e60 Compare March 20, 2024 14:53
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from eb52bb7 to 37f6f3a Compare March 20, 2024 14:53
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbyinterval branch from 67c6e60 to ec47926 Compare March 20, 2024 16:02
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from 37f6f3a to 70ba902 Compare March 20, 2024 16:02
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbyinterval branch from ec47926 to 4a074e0 Compare March 20, 2024 19:04
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from 70ba902 to 4d27721 Compare March 20, 2024 19:04
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbyinterval branch from 4a074e0 to 388b328 Compare March 20, 2024 19:19
@mafredri mafredri changed the title feat(coderd/database): rewrite *ByTemplate insights queries to use template_usage_stats feat(coderd/database): use template_usage_stats in *ByTemplate insights queries Mar 25, 2024
@mafredri mafredri force-pushed the mafredri/rewrite-getuseractivityinsights branch from e00136a to a5ff3ff Compare March 25, 2024 11:18
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from a4237e8 to a20a9f6 Compare March 25, 2024 11:18
@mafredri mafredri force-pushed the mafredri/rewrite-getuseractivityinsights branch from a5ff3ff to f5ecbef Compare March 25, 2024 11:55
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from a20a9f6 to c08e2f7 Compare March 25, 2024 11:55
@mafredri mafredri force-pushed the mafredri/rewrite-getuseractivityinsights branch from f5ecbef to 6f71125 Compare March 25, 2024 12:03
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from c08e2f7 to 7e9a5c9 Compare March 25, 2024 12:03
@mafredri mafredri force-pushed the mafredri/rewrite-getuseractivityinsights branch from 6f71125 to d29fcb3 Compare March 25, 2024 12:52
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch 3 times, most recently from a9fadb5 to 9573615 Compare March 25, 2024 13:18
@mafredri mafredri marked this pull request as ready for review March 25, 2024 13:25
@mafredri Graphite App
Copy link
Member Author

mafredri commented Mar 25, 2024 •
edited
Loading

Merge activity

  • Mar 25, 9:33 AM EDT: @mafredri started a stack merge that includes this pull request via Graphite.
  • Mar 25, 10:17 AM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 25, 10:27 AM EDT: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'required', 'test-go-race').

@mafredri mafredri force-pushed the mafredri/rewrite-getuseractivityinsights branch from 6f7dc7b to cb975fc Compare March 25, 2024 14:08
Base automatically changed from mafredri/rewrite-getuseractivityinsights to main March 25, 2024 14:16
mafredri added 11 commits March 25, 2024 14:17
@mafredri
feat(coderd/database): rewrite GetTemplateInsightsByTemplate to use…
1f5fb4e 
… `template_usage_stats`
@mafredri
fix: implement GetTemplateInsightsByTemplate in dbmem
10a4e3f
@mafredri
Revert "fix: implement GetTemplateInsightsByTemplate in dbmem"
17157e6 
This reverts commit 1826e01.
@mafredri
Revert "feat(coderd/database): rewrite `GetTemplateInsightsByTemplate…
f92c18e 
…` to use `template_usage_stats`"

This reverts commit 3086721.
@mafredri
test(coderd/prometheusmetrics/insights): improve TestCollectInsights
5952fa6
@mafredri
rewrite query
53f5b2b
@mafredri
feat(coderd/database): rewrite GetTemplateAppInsightsByTemplate to …
3a76148 
…use `template_usage_stats`
@mafredri
Revert "feat(coderd/database): rewrite `GetTemplateAppInsightsByTempl…
3834089 
…ate` to use `template_usage_stats`"

This reverts commit 7502e72ee35127b7705deb5845ec00bc438b2404.
@mafredri
rewrite query
db3e700
@mafredri
rewrite test
365925d
@mafredri
expand tests
72f2404
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from 9573615 to 72f2404 Compare March 25, 2024 14:17
@mafredri mafredri merged commit b183236 into main Mar 25, 2024
@mafredri mafredri deleted the mafredri/rewrite-gettemplateinsightsbytemplate branch March 25, 2024 15:42
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@mtojek mtojek mtojek approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mafredri @johnstcn @mtojek