fix: Remove microsecond wait in peer.(*Channel) #1270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was implemented when our WebRTC code was much less hardened. It's likely this was a cause of some other problem. Closes #1076.
coadler
approved these changes
May 3, 2022
Codecov Report
@@ Coverage Diff @@
## main #1270 +/- ##
==========================================
- Coverage 66.10% 65.81% -0.30%
==========================================
Files 276 273 -3
Lines 18146 18024 -122
Branches 216 216
==========================================
- Hits 11996 11863 -133
- Misses 4911 4923 +12
+ Partials 1239 1238 -1
Continue to review full report at Codecov.
|
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
This was implemented when our WebRTC code was much less hardened. It's likely this was a cause of some other problem. Closes #1076.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was implemented when our WebRTC code was much less hardened.
It's likely this was a cause of some other problem.
Closes #1076.