chore: add more e2e template settings tests #12717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe17609 to
898d81f
Compare
|
I'm not super happy about this implementation, because it means running any "enterprise" test requires running all of the "non-enterprise" tests first, but it does work. All of the tests are still running on a single coderd instance, but it runs all of the tests that work without a license, then adds the license, and then runs more tests. |
kylecarbs
approved these changes
Mar 27, 2024
|
ok, I think I came up with a way to do this that I'm a lot happier with, because it makes these way easier to run partially/locally. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12504