Skip to content

chore: add api specific 404 #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2022
Merged

chore: add api specific 404 #1272

merged 1 commit into from
May 3, 2022

Conversation

coadler
Copy link
Contributor

@coadler coadler commented May 3, 2022

Prevents weird errors when routes are moved, like
#1205

Prevents weird errors when routes are moved, like
#1205
@coadler coadler self-assigned this May 3, 2022
@coadler coadler requested a review from kylecarbs May 3, 2022 14:14
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #1272 (694cff8) into main (eda85a0) will decrease coverage by 0.19%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main    #1272      +/-   ##
==========================================
- Coverage   66.09%   65.90%   -0.20%     
==========================================
  Files         277      277              
  Lines       18226    18230       +4     
  Branches      216      216              
==========================================
- Hits        12047    12015      -32     
- Misses       4934     4962      +28     
- Partials     1245     1253       +8     
Flag Coverage Δ
unittest-go-macos-latest 53.26% <16.66%> (-0.20%) ⬇️
unittest-go-postgres- 64.84% <16.66%> (-0.09%) ⬇️
unittest-go-ubuntu-latest 55.78% <16.66%> (+0.10%) ⬆️
unittest-go-windows-2022 51.66% <16.66%> (+0.03%) ⬆️
unittest-js 70.69% <ø> (ø)
Impacted Files Coverage Δ
coderd/coderd.go 95.57% <16.66%> (-2.16%) ⬇️
peer/channel.go 84.21% <0.00%> (-2.50%) ⬇️
peer/conn.go 80.58% <0.00%> (-2.22%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
agent/agent.go 65.90% <0.00%> (-1.86%) ⬇️
coderd/workspaceagents.go 57.90% <0.00%> (-0.94%) ⬇️
provisionerd/provisionerd.go 76.17% <0.00%> (-0.54%) ⬇️
peerbroker/listen.go 87.39% <0.00%> (ø)
provisioner/terraform/provision.go 72.30% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eda85a0...694cff8. Read the comment docs.

@coadler coadler merged commit e530ab2 into main May 3, 2022
@coadler coadler deleted the colin/api-404 branch May 3, 2022 14:22
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
Prevents weird errors when routes are moved, like
#1205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants