Skip to content

test(coderd): fix todo for increased accuracy in insights test #12727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2024
Merged

test(coderd): fix todo for increased accuracy in insights test #12727

merged 1 commit into from
Mar 25, 2024

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Mar 22, 2024 •
edited
Loading

This PR updates the tests in insights_test.go to enable commented-out scenarios. This behavior was fixed by previous PRs in this stack. Note that the updated golden files are correct since they are "second template only" meaning that the newly introduced data is considered as expected. In other golden files there is no change since "only count once" is applied.

This was referenced Mar 22, 2024
Merged
Merged
Merged
Merged
Merged
@mafredri Graphite App
Copy link
Member Author

mafredri commented Mar 22, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mafredri and the rest of your teammates on Graphite Graphite

@mafredri mafredri changed the base branch from mafredri/keep-only-1-day-of-agent-stats to mafredri/rewrite-gettemplateinsightsbytemplate March 22, 2024 15:41
@mafredri mafredri force-pushed the mafredri/03-22-test_coderd_fix_todo_for_increased_accuracy_in_insights_test branch from 3cd22e7 to 2eb4bd7 Compare March 22, 2024 15:41
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from 878d0b3 to 6eca349 Compare March 22, 2024 16:16
@mafredri mafredri force-pushed the mafredri/03-22-test_coderd_fix_todo_for_increased_accuracy_in_insights_test branch from 2eb4bd7 to f43a8b1 Compare March 22, 2024 16:16
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from 6eca349 to 7eb4477 Compare March 22, 2024 16:20
@mafredri mafredri force-pushed the mafredri/03-22-test_coderd_fix_todo_for_increased_accuracy_in_insights_test branch from f43a8b1 to e547a2d Compare March 22, 2024 16:20
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from 7eb4477 to 55e2d64 Compare March 22, 2024 17:11
@mafredri mafredri force-pushed the mafredri/03-22-test_coderd_fix_todo_for_increased_accuracy_in_insights_test branch from e547a2d to 3e810fb Compare March 22, 2024 17:11
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from 55e2d64 to a4237e8 Compare March 22, 2024 17:15
@mafredri mafredri force-pushed the mafredri/03-22-test_coderd_fix_todo_for_increased_accuracy_in_insights_test branch from 3e810fb to 601e4f9 Compare March 22, 2024 17:15
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from a4237e8 to a20a9f6 Compare March 25, 2024 11:18
@mafredri mafredri force-pushed the mafredri/03-22-test_coderd_fix_todo_for_increased_accuracy_in_insights_test branch from 601e4f9 to 1d60b49 Compare March 25, 2024 11:18
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from a20a9f6 to c08e2f7 Compare March 25, 2024 11:55
@mafredri mafredri force-pushed the mafredri/03-22-test_coderd_fix_todo_for_increased_accuracy_in_insights_test branch from 1d60b49 to 407eff8 Compare March 25, 2024 11:55
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from c08e2f7 to 7e9a5c9 Compare March 25, 2024 12:03
@mafredri mafredri force-pushed the mafredri/03-22-test_coderd_fix_todo_for_increased_accuracy_in_insights_test branch from 407eff8 to 138046b Compare March 25, 2024 12:04
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from 7e9a5c9 to 7e90441 Compare March 25, 2024 12:52
@mafredri mafredri force-pushed the mafredri/03-22-test_coderd_fix_todo_for_increased_accuracy_in_insights_test branch from 138046b to e518ad5 Compare March 25, 2024 12:52
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from 7e90441 to a9fadb5 Compare March 25, 2024 12:55
@mafredri mafredri force-pushed the mafredri/03-22-test_coderd_fix_todo_for_increased_accuracy_in_insights_test branch from e518ad5 to 11d9293 Compare March 25, 2024 12:55
@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from a9fadb5 to 9573615 Compare March 25, 2024 13:18
@mafredri mafredri force-pushed the mafredri/03-22-test_coderd_fix_todo_for_increased_accuracy_in_insights_test branch from 11d9293 to 1d53fae Compare March 25, 2024 13:18
@mafredri mafredri marked this pull request as ready for review March 25, 2024 13:26
@mafredri mafredri requested review from johnstcn and mtojek March 25, 2024 13:26
mtojek
mtojek approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mafredri Graphite App
Copy link
Member Author

mafredri commented Mar 25, 2024 •
edited
Loading

Merge activity

@mafredri mafredri force-pushed the mafredri/rewrite-gettemplateinsightsbytemplate branch from 9573615 to 72f2404 Compare March 25, 2024 14:17
Base automatically changed from mafredri/rewrite-gettemplateinsightsbytemplate to main March 25, 2024 15:42
@mafredri mafredri force-pushed the mafredri/03-22-test_coderd_fix_todo_for_increased_accuracy_in_insights_test branch from 1d53fae to 4eede5f Compare March 25, 2024 15:44
@mafredri mafredri merged commit 7e183db into main Mar 25, 2024
@mafredri mafredri deleted the mafredri/03-22-test_coderd_fix_todo_for_increased_accuracy_in_insights_test branch March 25, 2024 15:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@mtojek mtojek mtojek approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mafredri @johnstcn @mtojek