chore(codersdk): move all tailscale imports out of codersdk
#12735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, importing `codersdk` just to interact with the API requires importing tailscale, which causes builds to fail unless manually using our fork.
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
it imports tailscale
workspacesdkcodersdk
kylecarbs
reviewed
Mar 25, 2024
This reverts commit a5e7b2e.
kylecarbs
reviewed
Mar 26, 2024
| @@ -1,4 +1,4 @@ | |||
| package codersdk | |||
| package workspacesdk | |||
There was a problem hiding this comment.
Thoughts on merging this into workspaceagents.go and then renaming that file to workspacesdk.go?
There was a problem hiding this comment.
Personally I prefer them split up, since them together would be a file >1k lines
There was a problem hiding this comment.
I rearranged it a bit
…tions_to_workspacesdk_
kylecarbs
approved these changes
Mar 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, importing
codersdkjust to interact with the API requires importing tailscale, which causes builds to fail unless manually using our fork. Unfortunately this had to touch the healthcheck code as well, since it imported some tailscale types.