chore: remove middleware to request version and entitlement warnings #12750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
590af3d to
c9ea886
Compare
coadler
approved these changes
Mar 25, 2024
coadler
reviewed
Mar 25, 2024
mafredri
approved these changes
Mar 25, 2024
| @@ -67,8 +67,7 @@ const ( | |||
| varOrganizationSelect = "organization" | |||
| varDisableDirect = "disable-direct-connections" | |||
|
|
|||
| notLoggedInMessage = "You are not logged in. Try logging in using 'coder login <url>'." | |||
| notLoggedInURLSavedMessage = "You are not logged in. Try logging in using 'coder login'." | |||
| notLoggedInMessage = "You are not logged in. Try logging in using 'coder login <url>'." | |||
There was a problem hiding this comment.
Suggested change
| notLoggedInMessage = "You are not logged in. Try logging in using 'coder login <url>'." | |
| notLoggedInMessage = "You are not logged in. Try logging in using 'coder login [url]'." |
URL is sometimes optional, if we're only using on message then I'd prefer highlighting this.
There was a problem hiding this comment.
Well the funny thing is for you to get this message, you have to already hit the server.
There was a problem hiding this comment.
It seems like this shows the URL if you don't have it, and coder login if you do have it. That code wasn't really used properly!
This cleans up `root.go` a bit, adds tests for middleware HTTP transport functions, and removes two HTTP requests we always always performed previously when executing *any* client command. It should improve CLI performance (especially for users with higher latency).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up
root.goa bit, adds tests for middleware HTTP transport functions, and removes two HTTP requests we have always performed previously when executing any client command. It should improve CLI performance (especially for users with higher latency).Version information was already sent as a header to every request. This adds entitlement warnings to requests if they exist. This seems reasonable because it's rare for users to have entitlement warnings.
The only behavior this breaks is when running
coder logout; if you're already logged out, it will no longer error.I removed a test that regressed in this commit. It's for the deprecated command, so it seems minimal risk since it wasn't working anyways.