Skip to content

test(cli): prevent flake due to outdated build in TestSSH #12760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2024
Merged

test(cli): prevent flake due to outdated build in TestSSH #12760

merged 2 commits into from
Mar 26, 2024

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Mar 26, 2024 •
edited
Loading

I got a bit suspicious about all the flakes for TestSSH/Stdio_StartStoppedWorkspace_CleanStdout, so we now ensure the build has started before trying to start the agent.

https://github.com/coder/coder/actions/runs/8420752158/job/23056129504?pr=12675#step:5:919

    t.go:99: 2024-03-25 13:23:28.691 [info]  coderd: disconnected possibly outdated agent  workspace_id=9915a34a-ec63-4b80-a2db-303abd1a9a23  agent_id=689042a0-a6fa-44c7-a15a-9cf89d3b5979  request_id=78afb83d-6655-43ab-b9ef-e1824eaa27a8 ...

Fixes #12752

@mafredri mafredri self-assigned this Mar 26, 2024
@mafredri mafredri requested a review from johnstcn March 26, 2024 10:26
@mafredri mafredri changed the title test(cli): Prevent flake due to outdated build in TestSSH test(cli): prevent flake due to outdated build in TestSSH Mar 26, 2024
johnstcn
johnstcn approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do the same for TestSSH/StartStoppedWorkspace?

@johnstcn johnstcn mentioned this pull request Mar 26, 2024
Closed
@mafredri mafredri enabled auto-merge (squash) March 26, 2024 10:42
@mafredri mafredri merged commit f418ece into main Mar 26, 2024
@mafredri mafredri deleted the mafredri/test-cli-fix-agent-flake branch March 26, 2024 10:46
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test flake: TestSSH/StartStoppedWorkspace
2 participants
@mafredri @johnstcn