fix(coderd/database): improve perf of GetTemplateInsightsByInterval
#12773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
mafredri
commented
Mar 27, 2024
| THEN (d::timestamptz + (@interval_days::int || ' day')::interval) | ||
| ELSE @end_time::timestamptz | ||
| END AS to_ | ||
| LEAST( |
There was a problem hiding this comment.
LEAST is more performant than case.
mafredri
commented
Mar 27, 2024
| @@ -410,6 +413,7 @@ LEFT JOIN | |||
| template_usage_stats AS tus | |||
| ON | |||
| tus.start_time >= ts.from_ | |||
| AND tus.start_time < ts.to_ -- End time exclusion criteria optimization for index. | |||
There was a problem hiding this comment.
Main performance optimization.
mtojek
approved these changes
Mar 27, 2024
| @@ -410,6 +413,7 @@ LEFT JOIN | |||
| template_usage_stats AS tus | |||
| ON | |||
| tus.start_time >= ts.from_ | |||
| AND tus.start_time < ts.to_ -- End time exclusion criteria optimization for index. | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New: https://explain.dalibo.com/plan/ebf9692d3426f3bd
Old: https://explain.dalibo.com/plan/62eg2ca495g6f2gg
3s -> 61ms.
Refs #12122