Skip to content

docs: describe single region and multi-region deployments #12779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 3, 2024
Merged

docs: describe single region and multi-region deployments #12779

merged 14 commits into from
Apr 3, 2024

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Mar 27, 2024 •
edited
Loading

Related: #12429

Preview: https://github.com/coder/coder/blob/12429-deployments/docs/about/architecture.md

Changes:

  • Re-arrange sections in About/Architecture, components go first.
  • Describe Single region architecture
  • Describe Multi-region architecture

@mtojek mtojek self-assigned this Mar 27, 2024
@mtojek mtojek mentioned this pull request Mar 28, 2024
Closed
6 tasks
@mtojek mtojek changed the title docs: Describe single region and multi-region deployments docs: describe single region and multi-region deployments Mar 28, 2024
@mtojek mtojek requested a review from ericpaulsen March 29, 2024 14:01
@mtojek mtojek marked this pull request as ready for review March 29, 2024 14:01
@mtojek mtojek requested a review from mafredri March 29, 2024 14:01
ericpaulsen
ericpaulsen reviewed Mar 29, 2024
View reviewed changes
Copy link
Member

@ericpaulsen ericpaulsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made a few grammatical nits. other than that, looks great.

@mtojek mtojek requested a review from ericpaulsen March 29, 2024 15:09
mafredri
mafredri reviewed Apr 2, 2024
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on writing these, had some nits, comments and questions, but in general looks great.

@mtojek mtojek requested a review from mafredri April 2, 2024 13:41
mafredri
mafredri approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍🏻

@mtojek mtojek merged commit ac8d1c6 into main Apr 3, 2024
21 checks passed
@mtojek mtojek deleted the 12429-deployments branch April 3, 2024 10:45
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@ericpaulsen ericpaulsen Awaiting requested review from ericpaulsen

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtojek @mafredri @ericpaulsen