Skip to content

feat: allow verbose logging in coder server #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2022
Merged

feat: allow verbose logging in coder server #1280

merged 1 commit into from
May 3, 2022

Conversation

coadler
Copy link
Contributor

@coadler coadler commented May 3, 2022

No description provided.

@coadler coadler self-assigned this May 3, 2022
@coadler coadler requested a review from kylecarbs May 3, 2022 21:03
@codecov
Copy link

codecov bot commented May 3, 2022 •
edited
Loading

Codecov Report

Merging #1280 (26846fb) into main (0f9e30e) will increase coverage by 8.53%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #1280      +/-   ##
==========================================
+ Coverage   57.46%   65.99%   +8.53%     
==========================================
  Files         277      277              
  Lines       18230    18235       +5     
  Branches      216      216              
==========================================
+ Hits        10476    12035    +1559     
+ Misses       6603     4949    -1654     
- Partials     1151     1251     +100
Flag Coverage Δ
unittest-go-macos-latest 53.29% <40.00%> (+0.02%) ⬆️
unittest-go-postgres- 64.86% <40.00%> (?)
unittest-go-ubuntu-latest 55.72% <40.00%> (+0.06%) ⬆️
unittest-go-windows-2022 51.64% <40.00%> (-0.02%) ⬇️
unittest-js 70.69% <ø> (ø)
Impacted Files Coverage Δ
cli/server.go 57.43% <40.00%> (+3.51%) ⬆️
codersdk/provisionerdaemons.go 61.97% <0.00%> (-5.64%) ⬇️
provisioner/echo/serve.go 56.80% <0.00%> (-2.41%) ⬇️
agent/agent.go 65.90% <0.00%> (-0.62%) ⬇️
provisionerd/provisionerd.go 76.30% <0.00%> (+0.53%) ⬆️
coderd/workspaceagents.go 56.04% <0.00%> (+0.69%) ⬆️
provisioner/terraform/provision.go 72.70% <0.00%> (+0.81%) ⬆️
coderd/provisionerdaemons.go 62.98% <0.00%> (+1.34%) ⬆️
coderd/templates.go 62.29% <0.00%> (+1.63%) ⬆️
cli/cliui/provisionerjob.go 78.57% <0.00%> (+2.14%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f9e30e...26846fb. Read the comment docs.

@coadler coadler merged commit 9d2e788 into main May 3, 2022
@coadler coadler deleted the colin/verbose branch May 3, 2022 21:13
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@coadler @kylecarbs
feat: allow verbose logging in coder server (#1280)
beb92fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@coadler @kylecarbs @misskniss