chore: add validation errors to the cli output #12814
Conversation
Unfortunately the cli golden file code (which is the only unit test that makes sense for formatting output) does not handle errors. This is because all cli tests invoke the command from within Go, skipping the error handler. You can see this is how we run it in a test: Line 253 in cb1b2ba Refactoring this will likely break a lot of cli tests since the go I do not want to add a new golden file test for this formatter in this PR. We can come back to testing if we really have formatting drift issues. Edit: Just found an old issue I made: #11588. Exactly this. |
|
I made it yellow though! |
@Emyrk given this is now in place, should we add a couple tests to it to encompass the new functionality?
Looks great! Thanks |
Tests were added here. These cover all example errors, which covers the validation errors here. I'll rebase on main to get them. |
cb1b2ba to
13bd167
Compare
Closes #12575
Error:
{ Response: codersdk.Response{ Message: "Top level sdk error message.", Detail: "magic dust unavailable, please try again later", Validations: []codersdk.ValidationError{ { Field: "region", Detail: "magic dust is not available in your region", }, }, } Helper: "Have you tried turning it off and on again?" }Before:
After:
If you did not know,
coder exp example-error <subcommand>has a set of sub commands to see how different cli errors are rendered out. No need to make them occur naturally.