Skip to content

Conversation

kylecarbs
Copy link
Member

This was using Mac Make, which is missing some options:
https://github.com/coder/coder/runs/6265845123?check_suite_focus=true#step:10:6

@kylecarbs kylecarbs requested a review from coadler May 4, 2022 14:17
@kylecarbs kylecarbs enabled auto-merge (squash) May 4, 2022 14:19
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #1283 (af5c6f1) into main (9d2e788) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1283      +/-   ##
==========================================
- Coverage   65.98%   65.91%   -0.07%     
==========================================
  Files         276      276              
  Lines       18189    18189              
  Branches      216      216              
==========================================
- Hits        12002    11990      -12     
- Misses       4934     4945      +11     
- Partials     1253     1254       +1     
Flag Coverage Δ
unittest-go-macos-latest 53.57% <ø> (ø)
unittest-go-postgres- 64.92% <ø> (-0.12%) ⬇️
unittest-go-ubuntu-latest 55.82% <ø> (?)
unittest-js 70.69% <ø> (ø)
Impacted Files Coverage Δ
peer/conn.go 76.90% <0.00%> (-4.43%) ⬇️
peerbroker/listen.go 84.03% <0.00%> (-3.37%) ⬇️
coderd/workspaceagents.go 56.97% <0.00%> (-0.94%) ⬇️
agent/agent.go 65.28% <0.00%> (ø)
coderd/provisionerdaemons.go 62.98% <0.00%> (ø)
provisionerd/provisionerd.go 76.70% <0.00%> (+0.93%) ⬆️
provisioner/echo/serve.go 56.80% <0.00%> (+2.39%) ⬆️
peerbroker/dial.go 83.60% <0.00%> (+6.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d2e788...af5c6f1. Read the comment docs.

@kylecarbs kylecarbs merged commit e860cc4 into main May 4, 2022
@kylecarbs kylecarbs deleted the fixsite branch May 4, 2022 14:23
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs added a commit that referenced this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants