-
Notifications
You must be signed in to change notification settings - Fork 896
chore(site): upgrade storybook to v8 #12831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just had some questions for my own understanding
docs: { | ||
autodocs: false, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get why we're starting this off as false
, but this looks like it could be a cool feature to flip on at some point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe?! I see this as helpful for component libraries but not for internal component usage.
withRouter, | ||
withQuery, | ||
(Story) => { | ||
return ( | ||
<HelmetProvider> | ||
<Story /> | ||
</HelmetProvider> | ||
); | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does changing the decorators affect anything here? I would assume this wouldn't break anything, but I'm not sure if there's anything else I'm missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk why, to be honest, but I had to make the theme provider the last decorator to make it work.
actions: { | ||
argTypesRegex: "^(on|handler)[A-Z].*", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was reading up on this, and I think I get how it works
Did this basically make it so that for any stories that had props that started with on
or handle
automatically received a Storybook action function as the input?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess so but it is not necessary anymore.
Closes #12682