Skip to content

chore(site): upgrade storybook to v8 #12831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 1, 2024
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

Closes #12682

@BrunoQuaresma BrunoQuaresma requested review from aslilac and a team April 1, 2024 14:14
@BrunoQuaresma BrunoQuaresma self-assigned this Apr 1, 2024
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just had some questions for my own understanding

Comment on lines +42 to +44
docs: {
autodocs: false,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get why we're starting this off as false, but this looks like it could be a cool feature to flip on at some point

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe?! I see this as helpful for component libraries but not for internal component usage.

Comment on lines +17 to +25
withRouter,
withQuery,
(Story) => {
return (
<HelmetProvider>
<Story />
</HelmetProvider>
);
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does changing the decorators affect anything here? I would assume this wouldn't break anything, but I'm not sure if there's anything else I'm missing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk why, to be honest, but I had to make the theme provider the last decorator to make it work.

Comment on lines -52 to -54
actions: {
argTypesRegex: "^(on|handler)[A-Z].*",
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was reading up on this, and I think I get how it works
Did this basically make it so that for any stories that had props that started with on or handle automatically received a Storybook action function as the input?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess so but it is not necessary anymore.

@BrunoQuaresma BrunoQuaresma merged commit 7c1d10b into main Apr 1, 2024
@BrunoQuaresma BrunoQuaresma deleted the bq/upgrade-storybook-8 branch April 1, 2024 19:12
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Storybook to v8
2 participants