Skip to content

feat(install.sh): add support for --mainline (default) and --stable #12858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2024
Merged

feat(install.sh): add support for --mainline (default) and --stable #12858

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
339acb9
feat(install.sh): add support for `--mainline` (default) and `--stable`
mafredri Apr 3, 2024
ace59df
add advisory message
mafredri Apr 3, 2024
473bc7e
s/backwards/backward/
mafredri Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat(install.sh): add support for --mainline (default) and --stable
  • Loading branch information
@mafredri
mafredri committed Apr 3, 2024
commit 339acb9a8a0c5d13888fbf19f1aa7556a9920b32
46 changes: 32 additions & 14 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,21 @@ The remote host must have internet access.
${not_curl_usage-}
Usage:

$arg0 [--dry-run] [--version X.X.X] [--edge] [--method detect] \
${arg0} [--dry-run] [--mainline | --stable | --version X.X.X] [--method detect] \
[--prefix ~/.local] [--rsh ssh] [user@host]

--dry-run
Echo the commands for the install process without running them.

--mainline
Install the latest mainline version (default).

--stable
Install the latest stable version instead of the latest mainline version.

--version X.X.X
Install a specific version instead of the latest.

--edge
Install the latest edge version instead of the latest stable version.

--method [detect | standalone]
Choose the installation method. Defaults to detect.
- detect detects the system package manager and tries to use it.
Expand Down Expand Up @@ -89,15 +92,26 @@ EOF
}

echo_latest_version() {
if [ "${EDGE-}" ]; then
version="$(curl -fsSL https://api.github.com/repos/coder/coder/releases | awk 'match($0,/.*"html_url": "(.*\/releases\/tag\/.*)".*/)' | head -n 1 | awk -F '"' '{print $4}')"
else
if [ "${MAINLINE}" = 0 ]; then
# https://gist.github.com/lukechilds/a83e1d7127b78fef38c2914c4ececc3c#gistcomment-2758860
version="$(curl -fsSLI -o /dev/null -w "%{url_effective}" https://github.com/coder/coder/releases/latest)"
fi
version="${version#https://github.com/coder/coder/releases/tag/}"
version="${version#v}"
echo "$version"
version="${version#https://github.com/coder/coder/releases/tag/v}"
else
# Fetch the releases from the GitHub API, sort by version number,
# and take the first result. Note that we're sorting by space-
# separated numbers and without utilizing the sort -V flag for the
# best compatibility.
version="$(
curl -fsSL https://api.github.com/repos/coder/coder/releases |
awk -F'"' '/"tag_name"/ {print $4}' |
tr -d v |
tr . ' ' |
sort -k1,1nr -k2,2nr -k3,3nr |
head -n1 |
tr ' ' .
)"
fi
echo "${version}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be confusing with VERSION

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the upper/lower case is a good enough distinction, and this practice (case) is often used to separate script global and function local variables. Although inherently case doesn’t differentiate between scope, for that local/typeset/declare needs to be used. Since we’re supporting posix shell though, we don’t try to use such “advance features”. 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, we can always adopt local keyword :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caveat emptor: https://unix.stackexchange.com/questions/493729/list-of-shells-that-support-local-keyword-for-defining-local-variables#493743

}

echo_standalone_postinstall() {
Expand Down Expand Up @@ -224,6 +238,7 @@ EOF
}

main() {
MAINLINE=1
TERRAFORM_VERSION="1.6.6"

if [ "${TRACE-}" ]; then
Expand All @@ -236,7 +251,6 @@ main() {
OPTIONAL \
ALL_FLAGS \
RSH_ARGS \
EDGE \
RSH \
WITH_TERRAFORM \
CAP_NET_ADMIN
Expand Down Expand Up @@ -282,8 +296,12 @@ main() {
--version=*)
VERSION="$(parse_arg "$@")"
;;
--edge)
EDGE=1
# Support edge for backwards compatibility.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: isn't it backward (no -s)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both forms seem to be used, but perhaps “backward” is the more common one.

--mainline | --edge)
MAINLINE=1
;;
--stable)
MAINLINE=0
;;
--rsh)
RSH="$(parse_arg "$@")"
Expand Down