Skip to content

chore: remove InsertWorkspaceAgentStat query #12869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 9, 2024
Merged

chore: remove InsertWorkspaceAgentStat query #12869

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6927c40
chore: remove InsertWorkspaceAgentStat query
Emyrk Apr 4, 2024
5fb2128
remove dbauthz test
Emyrk Apr 4, 2024
0fdac2d
fixup dbgen
Emyrk Apr 4, 2024
7ef1be3
fixup test:
Emyrk Apr 5, 2024
b3b1652
lint and remove accidental code
Emyrk Apr 5, 2024
f19fcbb
fix import
Emyrk Apr 5, 2024
5669b22
fixup test time comparison
Emyrk Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup test time comparison
  • Loading branch information
@Emyrk
Emyrk committed Apr 5, 2024
commit 5669b22a968466d72b8715bbc5e6f925ae698cee
10 changes: 8 additions & 2 deletions coderd/database/dbrollup/dbrollup_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,8 @@ func TestRollupTemplateUsageStats(t *testing.T) {
db, ps := dbtestutil.NewDB(t, dbtestutil.WithDumpOnFailure())
logger := slogtest.Make(t, &slogtest.Options{IgnoreErrors: true}).Leveled(slog.LevelDebug)

anHourAgo := dbtime.Now().Add(-time.Hour).Truncate(time.Hour)
anHourAndSixMonthsAgo := anHourAgo.AddDate(0, -6, 0)
anHourAgo := dbtime.Now().Add(-time.Hour).Truncate(time.Hour).UTC()
anHourAndSixMonthsAgo := anHourAgo.AddDate(0, -6, 0).UTC()

var (
org = dbgen.Organization(t, db, database.Organization{})
Expand Down Expand Up @@ -242,6 +242,12 @@ func TestRollupTemplateUsageStats(t *testing.T) {
require.NoError(t, err)
require.Len(t, stats, 1)

// I do not know a better way to do this. Our database runs in a *random*
// timezone. So the returned time is in a random timezone and fails on the
// equal even though they are the same time if converted back to the same timezone.
stats[0].EndTime = stats[0].EndTime.UTC()
stats[0].StartTime = stats[0].StartTime.UTC()

require.Equal(t, database.TemplateUsageStat{
TemplateID: tpl.ID,
UserID: user.ID,
Expand Down