fix(install.sh): remove extracted files after installation #12879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
06cf4a1 to
0889bfb
Compare
mtojek
approved these changes
Apr 5, 2024
| "$sh_c" cp "$CACHE_DIR/tmp/coder" "$STANDALONE_BINARY_LOCATION" | ||
|
|
||
| # Clean up the extracted files (note, not using sudo: $sh_c -> sh_c). | ||
| sh_c rm -rv "$CACHE_DIR/tmp" |
There was a problem hiding this comment.
nit it's possible to perform cleanup using traps too. Would implementing this practice here be helpful, or would it add unnecessary complexity?
There was a problem hiding this comment.
It's a good suggestion and definitely an option (unless shell compatibility is weak for some reason, haven't checked). Another option would be to split it up into two functions, where we:
mkdir .../tmp
if ! install_bin; then
rm -rf .../tmp
echo install failed
exit 1
fi
rm -rf .../tmp
For now though, I only want to make small changes to the script in stages/as needed, so we don't suddenly break it as there aren't really any tests I believe. 😅
There was a problem hiding this comment.
Alright, thanks for the guidance!
kylecarbs
approved these changes
Apr 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a subdirectory in
CACHE_DIRnamedtmpthat is deleted after installation.This is important because the script executes
sudo unzipwhich leaves files with root permission in the users personal cache directory~/.cache/coder. Removing the extracted files frees up 200 MB on the users drive as well. We don't attempt to fix past mistakes, but future users will be happier.Note: We should probably downgrade the unzip to run as normal user, no point in doing it as root. Fixed!