Skip to content

feat: add listening ports protocol selector #12915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 15, 2024
Merged

feat: add listening ports protocol selector #12915

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c986370
feat: add listening ports protocol selector
f0ssel Apr 9, 2024
d4c2e22
feature
f0ssel Apr 10, 2024
6fa90ab
fmt
f0ssel Apr 10, 2024
939858c
update title
f0ssel Apr 10, 2024
20ed5c1
make fmt
f0ssel Apr 10, 2024
36611ca
pr review
f0ssel Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update title
  • Loading branch information
@f0ssel
f0ssel committed Apr 10, 2024
commit 939858c8129f971e056ca5c546164729e4594e73
4 changes: 2 additions & 2 deletions site/src/modules/resources/PortForwardButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ export const PortForwardPopoverView: FC<PortForwardPopoverViewProps> = ({
justifyContent="space-between"
alignItems="start"
>
<HelpTooltipTitle>Listening ports</HelpTooltipTitle>
<HelpTooltipTitle>Listening Ports</HelpTooltipTitle>
<HelpTooltipLink
href={docs("/networking/port-forwarding#dashboard")}
>
Expand All @@ -253,7 +253,7 @@ export const PortForwardPopoverView: FC<PortForwardPopoverViewProps> = ({
</Stack>
<Stack direction="column" gap={1}>
<HelpTooltipText css={{ color: theme.palette.text.secondary }}>
{"The listening ports are exclusively accessible to you."}
{"The listening ports are exclusively accessible to you. Selecting HTTP/S will change the protocol for all listening ports."}
</HelpTooltipText>
<Stack
direction="row"
Expand Down