feat: implement deadline bumping from workspace app activity #12916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johnstcn brought up this: https://github.com/coder/coder/blob/main/coderd/agentapi/stats.go#L74 Apps should make connections to the workspace agent, incrementing the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11812
This is very inefficient in it's current state
The current interval at which these stats are flushed is 30s. There could be a large number of workspaces here, and this would essentially go against the work @mafredri did with rollups to reduce db load.
ActivityBumpWorkspacecannot be made to take multiple workspace ids because of thisLIMIT 1. Creating temporary tables for the "latest workspace build" has been a pain spot in so many queries.If we could make
ActivityBumpWorkspacetake multiple workspace ids, then this could be a decent patch for the time being?I think the best way to make it take multiple workspace ids is to create a view for
latest_builds. Then we can reuse that in all our queries.This might be the answer??
coder/coderd/database/queries/workspacebuilds.sql
Lines 78 to 92 in 5cec68b