Skip to content

chore: disable pgcoord (HA) when --in-memory #12919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Apr 9, 2024

HA does not make any sense while using in-memory database

Some enterprise e2e tests still fail.

Supports #12920

HA does not make any sense while using in-memory database
@Emyrk Emyrk requested a review from coadler April 9, 2024 22:15
@coadler coadler requested a review from spikecurtis April 10, 2024 01:13
@@ -55,7 +54,7 @@ export default defineConfig({
`--access-url=http://localhost:${coderPort}`,
`--http-address=localhost:${coderPort}`,
// Adding an enterprise license causes issues with pgcoord when running with `--in-memory`.
!enterpriseLicense && "--in-memory",
"--in-memory",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prolly don't need the comment above this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. 👍

@Emyrk Emyrk merged commit a607d56 into main Apr 10, 2024
25 of 26 checks passed
@Emyrk Emyrk deleted the stevenmasley/no_pgcord_inmem branch April 10, 2024 16:05
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants