Skip to content

test(site): fix flaky outdated agent test #12927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2024
Merged

test(site): fix flaky outdated agent test #12927

merged 1 commit into from
Apr 10, 2024

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Apr 10, 2024

Spotted in: #12508
Spotted in: https://github.com/coder/coder/actions/runs/8631687311/job/23660630419

This PR fixes the flaky outdatedAgent test.

@mtojek mtojek self-assigned this Apr 10, 2024
@mtojek mtojek requested a review from johnstcn April 10, 2024 14:05
@mtojek mtojek marked this pull request as ready for review April 10, 2024 14:05
@@ -17,6 +17,8 @@ const agentVersion = "v0.27.0";
test.beforeEach(async ({ page }) => await beforeCoderTest(page));

test("ssh with agent " + agentVersion, async ({ page }) => {
test.setTimeout(40_000); // This is a slow test, 20s may not be enough on Mac.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And they call them 'runners' :D

@mtojek mtojek merged commit e266ecf into main Apr 10, 2024
25 checks passed
@mtojek mtojek deleted the fix-e2e-flake branch April 10, 2024 14:09
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants