Skip to content

chore: skip global.setup if first user already exists #12930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 11, 2024
Merged

chore: skip global.setup if first user already exists #12930

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e6021d5
chore: skip global.setup if first user already exists
Emyrk Apr 10, 2024
1b721ed
fixup api route url
Emyrk Apr 10, 2024
7c382ab
add ui mode
Emyrk Apr 10, 2024
b9bc1a1
Fix package.json
Emyrk Apr 10, 2024
fb29ca4
remove boolean condition from setupAPICalls
Emyrk Apr 11, 2024
8f2fbc1
make fmt
Emyrk Apr 11, 2024
0d9e335
Update site/e2e/global.setup.ts
Emyrk Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix package.json
  • Loading branch information
@Emyrk
Emyrk committed Apr 10, 2024
commit b9bc1a189e57d5e69b0ab6aa3187ed956699403f
2 changes: 1 addition & 1 deletion site/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"playwright:install": "playwright install --with-deps chromium",
"playwright:test": "playwright test --config=e2e/playwright.config.ts",
"//": "If we are in a coder workspace, use the `ui-port` to allow opening remotely. If native, use the default app. It's generally a bit smoother to use.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls no, I hate these hacky "json comments" 😭

"playwright:test-ui": "playwright test --config=e2e/playwright.config.ts --ui `[[ \"$CODER\" == \"true\" ]] && --ui-port=7500 --ui-host=0.0.0.0`",
"playwright:test-ui": "playwright test --config=e2e/playwright.config.ts --ui $([[ \"$CODER\" == \"true\" ]] && echo --ui-port=7500 --ui-host=0.0.0.0)",
"gen:provisioner": "protoc --plugin=./node_modules/.bin/protoc-gen-ts_proto --ts_proto_out=./e2e/ --ts_proto_opt=outputJsonMethods=false,outputEncodeMethods=encode-no-creation,outputClientImpl=false,nestJs=false,outputPartialMethods=false,fileSuffix=Generated,suffix=hey -I ../provisionersdk/proto ../provisionersdk/proto/provisioner.proto && pnpm exec prettier --ignore-path '/dev/null' --cache --write './e2e/provisionerGenerated.ts'",
"storybook": "STORYBOOK=true storybook dev -p 6006",
"storybook:build": "storybook build",
Expand Down