feat(enterprise): add ready for handshake support to pgcoord #12935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
c40f0ab to
2dc196c
Compare
Base automatically changed from
colin/feat_add_agent_acks_to_in-memory_coordinator
to
main
April 10, 2024 22:15
ce96564 to
d7f72a8
Compare
spikecurtis
reviewed
Apr 11, 2024
coderd/database/queries/tailnet.sql
Outdated
| @@ -207,6 +207,12 @@ FROM tailnet_tunnels | |||
| INNER JOIN tailnet_peers ON tailnet_tunnels.src_id = tailnet_peers.id | |||
| WHERE tailnet_tunnels.dst_id = $1; | |||
|
|
|||
| -- name: PublishReadyForHandshake :exec | |||
| SELECT pg_notify( | |||
There was a problem hiding this comment.
Why is this a query instead of pubsub.Publish()?
There was a problem hiding this comment.
It made it easy to mock the call, and in the no-permission test make sure it wasn't being called
There was a problem hiding this comment.
not necessary anymore with your changes tho 👍
| "github.com/coder/coder/v2/testutil" | ||
| ) | ||
|
|
||
| func TestPGCoordinatorDual_ReadyForHandshake_OK(t *testing.T) { |
spikecurtis
approved these changes
Apr 12, 2024
| require.NoError(t, err) | ||
| defer coord1.Close() | ||
|
|
||
| agpltest.ReadyForHandshakeTest(ctx, t, coord1) |
There was a problem hiding this comment.
Very nice structure & code reuse
ba97700 to
1f0282d
Compare
1f0282d to
b2fc817
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.