Skip to content

fix(coderd): properly calculate query latency for tailnet queries #12944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Apr 11, 2024

The defer used seems correct, but the time.Since will always resolve
immediately since it's a param to the deferred function.

The defer used seems correct, but the `time.Since` will always resolve
immediately since it's a param to the deferred function.
Copy link
Contributor Author

coadler commented Apr 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @coadler and the rest of your teammates on Graphite Graphite

@coadler coadler changed the title fix(dbmetrics): properly calculate query latency for tailnet queries fix(coderd): properly calculate query latency for tailnet queries Apr 11, 2024
@coadler coadler marked this pull request as ready for review April 11, 2024 19:10
@coadler coadler requested a review from spikecurtis April 11, 2024 19:10
Copy link
Contributor

@spikecurtis spikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coadler coadler enabled auto-merge (squash) April 16, 2024 18:53
@coadler coadler merged commit 231fc26 into main Apr 16, 2024
@coadler coadler deleted the colin/fix_dbmetrics_properly_calculate_query_latency_for_tailnet_queries branch April 16, 2024 19:03
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants