Skip to content

chore: update generated array type definitions in TypeScript to be readonly #12947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 15, 2024
Merged

chore: update generated array type definitions in TypeScript to be readonly #12947

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3d6a2e6
chore: types generated handling readonly slices
Emyrk Apr 11, 2024
72d8788
add -update flag to update goldens
Emyrk Apr 11, 2024
dfd6068
revert excess gens
Emyrk Apr 11, 2024
bade802
fix: update most UI types to account for readonly modifiers
Parkreiner Apr 12, 2024
a622347
fix: remove accidental mutation from NavBarView
Parkreiner Apr 12, 2024
96693af
fix: remove mutation warning for BatchUpdateConfirmation stories
Parkreiner Apr 12, 2024
e4ea53a
fix: remove mutation warning for BactchUpdateConfirmation
Parkreiner Apr 12, 2024
6f69ae4
fix: format ActiveUserChart
Parkreiner Apr 12, 2024
0f6556c
fix: update import to make linter happy
Parkreiner Apr 12, 2024
a1040d7
fix: update fmt issue
Parkreiner Apr 12, 2024
1b1d6f6
fix: disable file write lint rule from unit test
Parkreiner Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: remove accidental mutation from NavBarView
  • Loading branch information
@Parkreiner
Parkreiner committed Apr 12, 2024
commit a622347cb444ad5235a1a672c90181ebeb0da69c
95 changes: 48 additions & 47 deletions site/src/modules/dashboard/Navbar/NavbarView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export interface NavbarViewProps {
logo_url?: string;
user?: TypesGen.User;
buildInfo?: TypesGen.BuildInfoResponse;
supportLinks?: TypesGen.LinkConfig[];
supportLinks?: readonly TypesGen.LinkConfig[];
onSignOut: () => void;
canViewAuditLog: boolean;
canViewDeployment: boolean;
Expand Down Expand Up @@ -342,57 +342,58 @@ const ProxyMenu: FC<ProxyMenuProps> = ({ proxyContextValue }) => {

<Divider css={{ borderColor: theme.palette.divider }} />

{proxyContextValue.proxies
?.sort((a, b) => {
const latencyA = latencies?.[a.id]?.latencyMS ?? Infinity;
const latencyB = latencies?.[b.id]?.latencyMS ?? Infinity;
return latencyA - latencyB;
})
.map((proxy) => (
<MenuItem
key={proxy.id}
selected={proxy.id === selectedProxy?.id}
css={{ fontSize: 14 }}
onClick={() => {
if (!proxy.healthy) {
displayError("Please select a healthy workspace proxy.");
{proxyContextValue.proxies &&
[...proxyContextValue.proxies]
Comment on lines +345 to +346
Copy link
Member

@Parkreiner Parkreiner Apr 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only change – check that proxies is defined, and then if it is, spread it into a new array, and mutate that instead of the original

All the other code is exactly the same

.sort((a, b) => {
const latencyA = latencies?.[a.id]?.latencyMS ?? Infinity;
const latencyB = latencies?.[b.id]?.latencyMS ?? Infinity;
return latencyA - latencyB;
})
.map((proxy) => (
<MenuItem
key={proxy.id}
selected={proxy.id === selectedProxy?.id}
css={{ fontSize: 14 }}
onClick={() => {
if (!proxy.healthy) {
displayError("Please select a healthy workspace proxy.");
closeMenu();
return;
}

proxyContextValue.setProxy(proxy);
closeMenu();
return;
}

proxyContextValue.setProxy(proxy);
closeMenu();
}}
>
<div
css={{
display: "flex",
gap: 24,
alignItems: "center",
width: "100%",
}}
>
<div css={{ width: 14, height: 14, lineHeight: 0 }}>
<img
src={proxy.icon_url}
alt=""
css={{
objectFit: "contain",
width: "100%",
height: "100%",
}}
<div
css={{
display: "flex",
gap: 24,
alignItems: "center",
width: "100%",
}}
>
<div css={{ width: 14, height: 14, lineHeight: 0 }}>
<img
src={proxy.icon_url}
alt=""
css={{
objectFit: "contain",
width: "100%",
height: "100%",
}}
/>
</div>

{proxy.display_name}

<Latency
latency={latencies?.[proxy.id]?.latencyMS}
isLoading={proxyLatencyLoading(proxy)}
/>
</div>

{proxy.display_name}

<Latency
latency={latencies?.[proxy.id]?.latencyMS}
isLoading={proxyLatencyLoading(proxy)}
/>
</div>
</MenuItem>
))}
</MenuItem>
))}

<Divider css={{ borderColor: theme.palette.divider }} />

Expand Down