Skip to content

feat: mask coder login token to enhance security #12948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 3, 2024
Merged

feat: mask coder login token to enhance security #12948

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
06b33fd
feat(login): treat coder token as a secret
michaelbrewer Apr 12, 2024
6918b55
Merge branch 'coder:main' into feat/coder-login-secret
michaelbrewer Apr 14, 2024
1afcb47
Update login.go
michaelbrewer Apr 14, 2024
dad9287
Merge branch 'coder:main' into feat/coder-login-secret
michaelbrewer Apr 20, 2024
586985b
Merge branch 'coder:main' into feat/coder-login-secret
michaelbrewer Apr 22, 2024
87a924d
Merge branch 'coder:main' into feat/coder-login-secret
michaelbrewer Apr 24, 2024
4222976
Merge branch 'coder:main' into feat/coder-login-secret
michaelbrewer Apr 25, 2024
47c2f16
Merge branch 'coder:main' into feat/coder-login-secret
michaelbrewer Apr 27, 2024
3b8dbc0
Merge branch 'coder:main' into feat/coder-login-secret
michaelbrewer May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cli/login.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,8 @@ func (r *RootCmd) login() *serpent.Command {
}

sessionToken, err = cliui.Prompt(inv, cliui.PromptOptions{
Text: "Paste your token here:",
Text: "Paste your token here:",
Secret: true,
Validate: func(token string) error {
client.SetSessionToken(token)
_, err := client.User(ctx, codersdk.Me)
Expand Down