Skip to content

fix: use CODER_AGENT_TOKEN for docker example #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2022
Merged

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented May 4, 2022

Since #1238 we are using CODER_AGENT_TOKEN instead of token. I think we're going to set up automated tests for all examples in the future.

@bpmct bpmct requested a review from ntimo May 4, 2022 22:36
@bpmct bpmct self-assigned this May 4, 2022
@bpmct bpmct requested a review from kylecarbs May 4, 2022 22:36
@bpmct bpmct enabled auto-merge (squash) May 4, 2022 22:38
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #1295 (9bbbd21) into main (0ccf010) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1295      +/-   ##
==========================================
- Coverage   66.10%   66.07%   -0.04%     
==========================================
  Files         281      277       -4     
  Lines       18424    18224     -200     
  Branches      220      220              
==========================================
- Hits        12180    12041     -139     
+ Misses       4982     4934      -48     
+ Partials     1262     1249      -13     
Flag Coverage Δ
unittest-go-macos-latest 53.57% <ø> (+0.01%) ⬆️
unittest-go-postgres- 64.96% <ø> (+0.08%) ⬆️
unittest-go-ubuntu-latest 55.97% <ø> (+0.09%) ⬆️
unittest-go-windows-2022 ?
unittest-js 71.61% <ø> (ø)
Impacted Files Coverage Δ
cli/configssh.go 62.04% <0.00%> (-6.57%) ⬇️
codersdk/provisionerdaemons.go 61.97% <0.00%> (-5.64%) ⬇️
cli/cliui/agent.go 77.19% <0.00%> (-5.27%) ⬇️
provisioner/echo/serve.go 54.40% <0.00%> (-4.81%) ⬇️
pty/ptytest/ptytest.go 86.95% <0.00%> (-4.35%) ⬇️
cli/templateinit.go 58.62% <0.00%> (-3.45%) ⬇️
agent/agent.go 65.28% <0.00%> (-0.62%) ⬇️
provisionerd/provisionerd.go 76.70% <0.00%> (-0.41%) ⬇️
pty/pty_windows.go
agent/usershell/usershell_windows.go
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ccf010...9bbbd21. Read the comment docs.

@bpmct bpmct merged commit 568574c into main May 4, 2022
@bpmct bpmct deleted the bpmct/fix-template-agent branch May 4, 2022 22:42
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants