Skip to content

feat: add warning about use of old/removed/invalid experiments #12962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 17, 2024
Merged

feat: add warning about use of old/removed/invalid experiments #12962

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4ab6e9c
Add experiments detail API & tests
dannykopping Apr 15, 2024
c65406e
make site/src/api/typesGenerated.ts
dannykopping Apr 15, 2024
31d5d60
Render invalid experiments warning
dannykopping Apr 15, 2024
bd10174
make gen
dannykopping Apr 15, 2024
ead1d7e
make site/src/api/typesGenerated.ts
dannykopping Apr 15, 2024
5e5f2ac
Reset all backend changes
dannykopping Apr 16, 2024
54f2462
Moving towards frontend-only solution
dannykopping Apr 16, 2024
acb0d03
Add storybook test
dannykopping Apr 16, 2024
66f7ef4
Appeasing the linter
dannykopping Apr 16, 2024
61d6595
Merge branch 'main' of github.com:/coder/coder into dk/old-exps
dannykopping Apr 17, 2024
69b26cb
Review feedback
dannykopping Apr 17, 2024
8836f25
Fixing e2e tests by displaying safe but unset experiments which was t…
dannykopping Apr 17, 2024
a604f17
Review comments
dannykopping Apr 17, 2024
236dc9d
make fmt
dannykopping Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Appeasing the linter 
Signed-off-by: Danny Kopping <danny@coder.com>
  • Loading branch information
@dannykopping
dannykopping committed Apr 16, 2024
commit 66f7ef46fd56196fba9dec4aae343ac61676e7da
20 changes: 10 additions & 10 deletions site/src/pages/DeploySettingsPage/GeneralSettingsPage/GeneralSettingsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import type {FC} from "react";
import {Helmet} from "react-helmet-async";
import {useQuery} from "react-query";
import {deploymentDAUs} from "api/queries/deployment";
import {entitlements} from "api/queries/entitlements";
import {availableExperiments, experiments} from "api/queries/experiments";
import {pageTitle} from "utils/page";
import {useDeploySettings} from "../DeploySettingsLayout";
import {GeneralSettingsPageView} from "./GeneralSettingsPageView";
import type { FC } from "react";
import { Helmet } from "react-helmet-async";
import { useQuery } from "react-query";
import { deploymentDAUs } from "api/queries/deployment";
import { entitlements } from "api/queries/entitlements";
import { availableExperiments, experiments } from "api/queries/experiments";
import { pageTitle } from "utils/page";
import { useDeploySettings } from "../DeploySettingsLayout";
import { GeneralSettingsPageView } from "./GeneralSettingsPageView";

const GeneralSettingsPage: FC = () => {
const {deploymentValues} = useDeploySettings();
const { deploymentValues } = useDeploySettings();
const deploymentDAUsQuery = useQuery(deploymentDAUs());
const entitlementsQuery = useQuery(entitlements());
const enabledExperimentsQuery = useQuery(experiments());
Expand Down
1 change: 0 additions & 1 deletion site/src/pages/DeploySettingsPage/GeneralSettingsPage/GeneralSettingsPageView.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import {
MockEntitlementsWithUserLimit,
} from "testHelpers/entities";
import { GeneralSettingsPageView } from "./GeneralSettingsPageView";
import {Experiments} from "../../../api/typesGenerated";

const meta: Meta<typeof GeneralSettingsPageView> = {
title: "pages/DeploySettingsPage/GeneralSettingsPageView",
Expand Down
16 changes: 12 additions & 4 deletions site/src/pages/DeploySettingsPage/GeneralSettingsPage/GeneralSettingsPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ export type GeneralSettingsPageViewProps = {
deploymentDAUs?: DAUsResponse;
deploymentDAUsError: unknown;
entitlements: Entitlements | undefined;
enabledExperiments: Experiments;
safeExperiments: Experiments;
enabledExperiments: Experiments | string[];
safeExperiments: Experiments | string[];
};

export const GeneralSettingsPageView: FC<GeneralSettingsPageViewProps> = ({
Expand All @@ -46,7 +46,7 @@ export const GeneralSettingsPageView: FC<GeneralSettingsPageViewProps> = ({
found = true;
return;
}
})
});

if (found) {
safe.push(exp);
Expand Down Expand Up @@ -92,7 +92,15 @@ export const GeneralSettingsPageView: FC<GeneralSettingsPageViewProps> = ({
))}
</ul>
It is recommended that you remove these experiments from your
configuration as they have no effect. See <a href="https://coder.com/docs/v2/latest/cli/server#--experiments" target="_blank">the documentation</a> for more details.
configuration as they have no effect. See{" "}
<a
href="https://coder.com/docs/v2/latest/cli/server#--experiments"
target="_blank"
rel="noreferrer"
>
the documentation
</a>{" "}
for more details.
</Alert>
)}
<OptionsTable
Expand Down
Loading