Skip to content

chore: deprecate gauge metrics with _total suffix (#12744) #12976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2024
Merged

chore: deprecate gauge metrics with _total suffix (#12744) #12976

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae1b62c
chore: deprecate gauge metrics with _total suffix (#12744)
snark87 Apr 6, 2024
39c45e6
Merge remote-tracking branch 'origin/main' into deprecated-metrics
snark87 Apr 18, 2024
5a948fe
Apply suggestions from code review
snark87 Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
add link to follow-up issue

Co-authored-by: Cian Johnston <public@cianjohnston.ie>
  • Loading branch information
@snark87 @johnstcn
snark87 and johnstcn authored Apr 18, 2024
commit 5a948fe79cadd3e339f6fdd7cfa0c93c3ed78f64
1 change: 1 addition & 0 deletions coderd/prometheusmetrics/prometheusmetrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ func Workspaces(ctx context.Context, logger slog.Logger, registerer prometheus.R
}

// TODO: deprecated: remove in the future
// See: https://github.com/coder/coder/issues/12999
// Deprecation reason: gauge metrics should avoid suffix `_total``
workspaceLatestBuildTotalsDeprecated := prometheus.NewGaugeVec(prometheus.GaugeOpts{
Namespace: "coderd",
Expand Down
1 change: 1 addition & 0 deletions coderd/promoauth/oauth2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ func NewFactory(registry prometheus.Registerer) *Factory {
"resource",
}),
// TODO: deprecated: remove in the future
// See: https://github.com/coder/coder/issues/12999
// Deprecation reason: gauge metrics should avoid suffix `_total``
rateLimitDeprecated: factory.NewGaugeVec(prometheus.GaugeOpts{
Namespace: "coderd",
Expand Down
Loading