chore: reduce dashboard requests from seeded data #13034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already inject all of this content in `index.html`. There was also a bug with displaying a loading indicator when the workspace proxies endpoint 404s.
1587c7f to
fd977e2
Compare
site/src/api/queries/users.ts
Outdated
| queryKey: meKey, | ||
| initialData: initialUserData, | ||
| queryFn: API.getAuthenticatedUser, | ||
| }; | ||
| // If we have initial user data, we don't want to fetch | ||
| // the user again. We already have it! | ||
| if (initialUserData) { |
There was a problem hiding this comment.
I think we may could create some util in api/queries/utils to reuse the cache configuration across queries:
export const cachedQuery = {
cacheTime: Infinity,
staleTime: Infinity,
refetchOnMount: false,
refetchOnReconnect: false,
refetchOnWindowFocus: false,
}So it could be used like this:
const opts: UseQueryOptions<BuildInfoResponse> = {
...cachedQuery,
queryKey: buildInfoKey,
initialData: initialBuildInfoData,
queryFn: () => API.getBuildInfo(),
};|
@BrunoQuaresma will do! |
BrunoQuaresma
approved these changes
Apr 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already inject all of this content in
index.html.There was also a bug with displaying a loading indicator when the workspace proxies endpoint 404s.