Skip to content

chore: change site_configs.value to text #13036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2024
Merged

chore: change site_configs.value to text #13036

merged 2 commits into from
Apr 22, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Apr 22, 2024

We're planning to add support for custom "Terms of Service" notifications, and customers will likely want to be able to specify values much longer than 8k characters for this. The limited text length for this table is pretty arbitrary, and (at least with Postgres) using character varying doesn't really provide any advantages over text in like 99% of cases.

@aslilac aslilac requested a review from f0ssel April 22, 2024 19:21
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@f0ssel f0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@aslilac aslilac merged commit fab5591 into main Apr 22, 2024
25 checks passed
@aslilac aslilac deleted the site_configs_text branch April 22, 2024 23:25
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants